Skip to content

matter: update data model and enable mandatory cmds #24029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2025
Merged

matter: update data model and enable mandatory cmds #24029

merged 1 commit into from
Aug 26, 2025
+1,277 −1,021

Conversation

doublemis1
Copy link
Contributor

Update matter samples data model.

  • enable VID verification commands.
  • set identify cluster revision to 6

@doublemis1 doublemis1 requested review from a team as code owners August 18, 2025 10:35
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 18, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 18, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: 3333bc7ab7ba6ba64c08106a3b9e39e70cfd307d

more details

sdk-nrf:

PR head: 3333bc7ab7ba6ba64c08106a3b9e39e70cfd307d
merge base: 57bb508a3cb441ed905426c77d04abfa942ba42e
target head (main): b4058d7d06620b71fff81757ecf8eb119716bc45
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (84) 
applications
│  ├── matter_bridge
│  │  ├── snippets
│  │  │  ├── onoff_plug
│  │  │  │  ├── bridge.matter
│  │  │  │  ├── bridge.zap
│  │  │  │  ├── zap-generated
│  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  ├── access.h
│  │  │  │  │  ├── endpoint_config.h
│  │  │  │  │  │ gen_config.h
│  │  ├── src
│  │  │  ├── default_zap
│  │  │  │  ├── bridge.matter
│  │  │  │  ├── bridge.zap
│  │  │  │  ├── zap-generated
│  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  ├── access.h
│  │  │  │  │  ├── endpoint_config.h
│  │  │  │  │  │ gen_config.h
│  ├── matter_weather_station
│  │  ├── src
│  │  │  ├── default_zap
│  │  │  │  ├── weather-station.matter
│  │  │  │  ├── weather-station.zap
│  │  │  │  ├── zap-generated
│  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  ├── access.h
│  │  │  │  │  ├── endpoint_config.h
│  │  │  │  │  │ gen_config.h
samples
│  ├── matter
│  │  ├── common
│  │  │  ├── src
│  │  │  │  ├── certification
│  │  │  │  │  ├── thread_platform
│  │  │  │  │  │  ├── thread_certification.matter
│  │  │  │  │  │  ├── thread_certification.zap
│  │  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  │  │ endpoint_config.h
│  │  ├── light_bulb
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── light_bulb.matter
│  │  │  │  │  ├── light_bulb.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  │  ├── access.h
│  │  │  │  │  │  ├── endpoint_config.h
│  │  │  │  │  │  │ gen_config.h
│  │  ├── light_switch
│  │  │  ├── snippets
│  │  │  │  ├── lit_icd
│  │  │  │  │  ├── light_switch.matter
│  │  │  │  │  ├── light_switch.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  │  ├── access.h
│  │  │  │  │  │  ├── endpoint_config.h
│  │  │  │  │  │  │ gen_config.h
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── light_switch.matter
│  │  │  │  │  ├── light_switch.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  │  ├── access.h
│  │  │  │  │  │  ├── endpoint_config.h
│  │  │  │  │  │  │ gen_config.h
│  │  ├── lock
│  │  │  ├── snippets
│  │  │  │  ├── schedules
│  │  │  │  │  ├── lock.matter
│  │  │  │  │  ├── lock.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  │  ├── access.h
│  │  │  │  │  │  ├── endpoint_config.h
│  │  │  │  │  │  │ gen_config.h
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── lock.matter
│  │  │  │  │  ├── lock.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  │  ├── access.h
│  │  │  │  │  │  ├── endpoint_config.h
│  │  │  │  │  │  │ gen_config.h
│  │  ├── manufacturer_specific
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── manufacturer_specific.matter
│  │  │  │  │  ├── manufacturer_specific.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  │  ├── PluginApplicationCallbacks.h
│  │  │  │  │  │  ├── access.h
│  │  │  │  │  │  ├── callback-stub.cpp
│  │  │  │  │  │  ├── endpoint_config.h
│  │  │  │  │  │  │ gen_config.h
│  │  ├── smoke_co_alarm
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── smoke_co_alarm.matter
│  │  │  │  │  ├── smoke_co_alarm.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  │  ├── access.h
│  │  │  │  │  │  ├── endpoint_config.h
│  │  │  │  │  │  │ gen_config.h
│  │  ├── template
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── template.matter
│  │  │  │  │  ├── template.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  │  ├── access.h
│  │  │  │  │  │  ├── endpoint_config.h
│  │  │  │  │  │  │ gen_config.h
│  │  ├── thermostat
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── thermostat.matter
│  │  │  │  │  ├── thermostat.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  │  ├── access.h
│  │  │  │  │  │  ├── endpoint_config.h
│  │  │  │  │  │  │ gen_config.h
│  │  ├── window_covering
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── window-app.matter
│  │  │  │  │  ├── window-app.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  │  ├── access.h
│  │  │  │  │  │  ├── endpoint_config.h
│  │  │  │  │  │  │ gen_config.h
scripts
│  │ quarantine.yaml

Outputs:

Toolchain

Version: c5be9c56c7
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:c5be9c56c7_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 93
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-chip
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions GitHub Actions
Copy link

You can find the documentation preview for this PR here.

kkasperczyk-no
kkasperczyk-no reviewed Aug 18, 2025
View reviewed changes
Copy link
Contributor

@kkasperczyk-no kkasperczyk-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you re-generate source files for manufacturer-specifc sample and thread_certification? I can see only change in .zap and .matter files, but not in zap-generated directory

@doublemis1
Copy link
Contributor Author

Did you re-generate source files for manufacturer-specifc sample and thread_certification? I can see only change in .zap and .matter files, but not in zap-generated directory

will check it twice, thanks!

@doublemis1
matter: update data model and enable mandatory cmds
3333bc7 
Update matter samples data model.
 * enable VID verification commands.
 * set identify cluster revision to 6

Signed-off-by: Michał Szablowski <[email protected]>
@doublemis1 doublemis1 requested a review from a team as a code owner August 19, 2025 11:51
@github-actions GitHub Actions
Copy link

Since quarantine was modified, please make sure you are following the process described in Quarantine Process.

@NordicBuilder
Copy link
Contributor

Memory footprint analysis revealed the following potential issues

sample.matter.template.debug[nrf52840dk/nrf52840]: ROM size increased by 3488[B] in comparison to the main[57bb508] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.debug[nrf5340dk/nrf5340/cpuapp]: ROM size increased by 3708[B] in comparison to the main[57bb508] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf7002dk/nrf5340/cpuapp]: ROM size increased by 1612[B] in comparison to the main[57bb508] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.debug[nrf7002dk/nrf5340/cpuapp]: ROM size increased by 2068[B] in comparison to the main[57bb508] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf52840dk/nrf52840]: ROM size increased by 2960[B] in comparison to the main[57bb508] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf5340dk/nrf5340/cpuapp]: ROM size increased by 3076[B] in comparison to the main[57bb508] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-24029/6)

@doublemis1
Copy link
Contributor Author

@nrfconnect/ncs-co-build-system Please review

@kkasperczyk-no
Copy link
Contributor

@nrfconnect/ncs-co-build-system this change is required to be back-ported to v3.1 branch, please review soon.

@nordicjm
Copy link
Contributor

@nrfconnect/ncs-co-build-system Please review

I don't see why the review is required on a bunch of random auto generated code which has no CMake or Kconfig changes

@ArekBalysNordic ArekBalysNordic merged commit 4566a49 into nrfconnect:main Aug 26, 2025
19 checks passed
@kkasperczyk-no
Copy link
Contributor

@nrfconnect/ncs-co-build-system Please review

I don't see why the review is required on a bunch of random auto generated code which has no CMake or Kconfig changes

@nordicjm I think that this particular PR triggered your review, because it modifies snippets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuDuda LuDuda LuDuda approved these changes

@nordicjm nordicjm nordicjm approved these changes

@kkasperczyk-no kkasperczyk-no kkasperczyk-no approved these changes

@nordic-piks nordic-piks nordic-piks approved these changes

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@doublemis1 @NordicBuilder @kkasperczyk-no @nordicjm @LuDuda @nordic-piks @ArekBalysNordic